diff options
| author | mtei <2170248+mtei@users.noreply.github.com> | 2019-01-10 12:04:01 +0900 |
|---|---|---|
| committer | Drashna Jaelre <drashna@live.com> | 2019-01-25 13:38:12 -0800 |
| commit | 2e8b32b9b5434c6cee011ef953f3ad3ec8a099e7 (patch) | |
| tree | 6ecf6ce637de16989672b8de78042e7366e8f6b5 | |
| parent | 79b58937f41413f52ffc7b6af2149dca7a632b73 (diff) | |
| download | qmk_firmware-2e8b32b9b5434c6cee011ef953f3ad3ec8a099e7.tar.gz qmk_firmware-2e8b32b9b5434c6cee011ef953f3ad3ec8a099e7.zip | |
move `#include "rgb.h"` from quantum.h to quantum.c
I think `quantum.h` should contain only API declarations that `quantum.c` provides externally. `rgb.h` contains function weak definitions. This should not be in `quantum.h`.
| -rw-r--r-- | quantum/quantum.c | 5 | ||||
| -rw-r--r-- | quantum/quantum.h | 3 |
2 files changed, 5 insertions, 3 deletions
diff --git a/quantum/quantum.c b/quantum/quantum.c index 85db100ab4..5d8ffe34eb 100644 --- a/quantum/quantum.c +++ b/quantum/quantum.c @@ -15,6 +15,11 @@ */ #include "quantum.h" + +#if !defined(RGBLIGHT_ENABLE) && !defined(RGB_MATRIX_ENABLE) + #include "rgb.h" +#endif + #ifdef PROTOCOL_LUFA #include "outputselect.h" #endif diff --git a/quantum/quantum.h b/quantum/quantum.h index f78915fdfb..56a6a1a991 100644 --- a/quantum/quantum.h +++ b/quantum/quantum.h @@ -30,9 +30,6 @@ #ifdef BACKLIGHT_ENABLE #include "backlight.h" #endif -#if !defined(RGBLIGHT_ENABLE) && !defined(RGB_MATRIX_ENABLE) - #include "rgb.h" -#endif #ifdef RGBLIGHT_ENABLE #include "rgblight.h" #else |