diff options
| author | Ramon Imbao <ramonimbao@gmail.com> | 2021-12-09 01:38:47 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-08 09:38:47 -0800 |
| commit | c09837e092ff3c8e74dde8567ef9eb3e7a343805 (patch) | |
| tree | bef84436c8451a61595fd98931a2b121d5af595a | |
| parent | cf9239a88277b0fbdd6de184374c6c84c39d8d8f (diff) | |
| download | qmk_firmware-c09837e092ff3c8e74dde8567ef9eb3e7a343805.tar.gz qmk_firmware-c09837e092ff3c8e74dde8567ef9eb3e7a343805.zip | |
[Keyboard] Flip encoder and fix weird volume behavior for Herringbone Pro (#15423)
Co-authored-by: Joel Challis <git@zvecr.com>
| -rw-r--r-- | keyboards/ramonimbao/herringbone/pro/config.h | 4 | ||||
| -rw-r--r-- | keyboards/ramonimbao/herringbone/pro/keymaps/via/keymap.c | 2 |
2 files changed, 4 insertions, 2 deletions
diff --git a/keyboards/ramonimbao/herringbone/pro/config.h b/keyboards/ramonimbao/herringbone/pro/config.h index 20f92282b0..4aab52fcb5 100644 --- a/keyboards/ramonimbao/herringbone/pro/config.h +++ b/keyboards/ramonimbao/herringbone/pro/config.h @@ -48,8 +48,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. #define DIODE_DIRECTION COL2ROW /* Encoder pin assignment */ -#define ENCODERS_PAD_A { C2 } -#define ENCODERS_PAD_B { C3 } +#define ENCODERS_PAD_A { C3 } +#define ENCODERS_PAD_B { C2 } /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ #define DEBOUNCE 5 diff --git a/keyboards/ramonimbao/herringbone/pro/keymaps/via/keymap.c b/keyboards/ramonimbao/herringbone/pro/keymaps/via/keymap.c index fceca1a8bd..8acc017679 100644 --- a/keyboards/ramonimbao/herringbone/pro/keymaps/via/keymap.c +++ b/keyboards/ramonimbao/herringbone/pro/keymaps/via/keymap.c @@ -88,12 +88,14 @@ bool encoder_update_user(uint8_t index, bool clockwise) { encoder_cw.pressed = true; encoder_cw.time = (timer_read() | 1); action_exec(encoder_cw); + wait_ms(20); anim_sleep = timer_read32(); oled_on(); } else { encoder_ccw.pressed = true; encoder_ccw.time = (timer_read() | 1); action_exec(encoder_ccw); + wait_ms(20); anim_sleep = timer_read32(); oled_on(); } |