summaryrefslogtreecommitdiff
path: root/Dockerfile
diff options
context:
space:
mode:
authorRyan MacLean <ryan@ryanmaclean.com>2017-04-30 15:04:00 -0700
committerGitHub <noreply@github.com>2017-04-30 15:04:00 -0700
commit7ce94eb468ff34f904f8ef8fdeb3c5fe2d09d78c (patch)
treeb3c8b25a6ad9a874f38b6f58b838ab9aa5afccda /Dockerfile
parent26b51383b2e387b3f1c4f257aa91d97d2e8ef6c9 (diff)
downloadqmk_firmware-7ce94eb468ff34f904f8ef8fdeb3c5fe2d09d78c.tar.gz
qmk_firmware-7ce94eb468ff34f904f8ef8fdeb3c5fe2d09d78c.zip
Cleaning Up Dockerfile Layers Per Official Docs
From the official docs: ``` Note: The official Debian and Ubuntu images automatically run apt-get clean, so explicit invocation is not required. ``` Also added ` && rm -rf /var/lib/apt/lists/*` as part of the install line which probably does what was intended (no need to make a new layer). Added apt-get update to the RUN payload, as it should be part of the same layer. Both are documented here: https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/
Diffstat (limited to 'Dockerfile')
-rw-r--r--Dockerfile9
1 files changed, 3 insertions, 6 deletions
diff --git a/Dockerfile b/Dockerfile
index 744ded8579..88da06f02a 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,8 +1,7 @@
FROM debian:jessie
MAINTAINER Erik Dasque <erik@frenchguys.com>
-RUN apt-get update
-RUN apt-get install --no-install-recommends -y build-essential \
+RUN apt-get update && apt-get install --no-install-recommends -y build-essential \
gcc \
unzip \
wget \
@@ -15,10 +14,8 @@ RUN apt-get install --no-install-recommends -y build-essential \
gcc-arm-none-eabi \
binutils-arm-none-eabi \
libnewlib-arm-none-eabi \
- git
-
-RUN apt-get clean
-RUN rm -rf /var/lib/apt/lists/*
+ git \
+ && rm -rf /var/lib/apt/lists/*
ENV keyboard=ergodox
ENV subproject=ez