diff options
| author | Michael Stapelberg <stapelberg@users.noreply.github.com> | 2021-05-19 22:43:36 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-20 06:43:36 +1000 |
| commit | 82aa9ad4a567695d1f7d0b1e36bf8563d2967813 (patch) | |
| tree | 4f27b34928fb3ddbfaf0af8cde0ce701721bd624 /keyboards/eggman | |
| parent | 068af97b7aac1fc787b5e9fb76d9250d48638e58 (diff) | |
| download | qmk_firmware-82aa9ad4a567695d1f7d0b1e36bf8563d2967813.tar.gz qmk_firmware-82aa9ad4a567695d1f7d0b1e36bf8563d2967813.zip | |
matrix: wait for row signal to go HIGH for every row (#12945)
I noticed this discrepancy (last row of the matrix treated differently than the
others) when optimizing the input latency of my keyboard controller, see also
https://michael.stapelberg.ch/posts/2021-05-08-keyboard-input-latency-qmk-kinesis/
Before this commit, when tuning the delays I noticed ghost key presses when
pressing the F2 key, which is on the last row of the keyboard matrix: the
dead_grave key, which is on the first row of the keyboard matrix, would be
incorrectly detected as pressed.
After this commit, all keyboard matrix rows are interpreted correctly.
I suspect that my setup is more susceptible to this nuance than others because I
use GPIO_INPUT_PIN_DELAY=0 and hence don’t have another delay that might mask
the problem.
Diffstat (limited to 'keyboards/eggman')
0 files changed, 0 insertions, 0 deletions