diff options
| author | James Young <18669334+noroadsleft@users.noreply.github.com> | 2021-08-15 20:51:13 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-16 06:51:13 +1000 |
| commit | 4b453dca92f87899d98b5340b16677bd78a52beb (patch) | |
| tree | a40b8e53964520762946e0c63bfc0a83cb2a3428 /keyboards/hhkb | |
| parent | fd340f8957055d74b26a5ddc490253fcc8a3a2f7 (diff) | |
| download | qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.tar.gz qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.zip | |
Remove MIDI Configuration boilerplate (#11151)
* remove keyboard-level instances of `MIDI_ENABLE = no`
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} +
```
Co-Authored-By: Nick Brassel <nick@tzarc.org>
* fix case-sensitivity issues on MIDI_ENABLE
Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} +
```
* replace `# MIDI controls` with `# MIDI support`
Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} +
```
* align inline comments
Aligns the inline comments to the length used by the QMK AVR rules.mk template.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} +
```
* remove commented instances of `MIDI_ENABLE` from keyboard `rules.mk` files
Commands:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} +
```
* remove MIDI configuration boilerplate from keyboard config.h files
Co-authored-by: Nick Brassel <nick@tzarc.org>
Diffstat (limited to 'keyboards/hhkb')
| -rw-r--r-- | keyboards/hhkb/ansi/rules.mk | 2 | ||||
| -rw-r--r-- | keyboards/hhkb/jp/rules.mk | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/keyboards/hhkb/ansi/rules.mk b/keyboards/hhkb/ansi/rules.mk index 6eedc149da..56c7fd7719 100644 --- a/keyboards/hhkb/ansi/rules.mk +++ b/keyboards/hhkb/ansi/rules.mk @@ -24,7 +24,7 @@ CUSTOM_MATRIX = yes # Custom matrix file for the HHKB # SLEEP_LED_ENABLE = yes # Breathing sleep LED during USB suspend # NKRO_ENABLE = yes # USB Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work # BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -# MIDI_ENABLE = yes # MIDI controls +MIDI_ENABLE = no # MIDI support # UNICODE_ENABLE = yes # Unicode # BLUETOOTH_ENABLE = yes # Enable Bluetooth with the Adafruit EZ-Key HID diff --git a/keyboards/hhkb/jp/rules.mk b/keyboards/hhkb/jp/rules.mk index 36de7bc22f..1902cf4325 100644 --- a/keyboards/hhkb/jp/rules.mk +++ b/keyboards/hhkb/jp/rules.mk @@ -24,7 +24,7 @@ CUSTOM_MATRIX = yes # Custom matrix file for the HHKB # SLEEP_LED_ENABLE = yes # Breathing sleep LED during USB suspend # NKRO_ENABLE = yes # USB Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work # BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -# MIDI_ENABLE = yes # MIDI controls +MIDI_ENABLE = no # MIDI support # UNICODE_ENABLE = yes # Unicode # BLUETOOTH_ENABLE = yes # Enable Bluetooth with the Adafruit EZ-Key HID |