diff options
| author | tengg <tengg@users.noreply.github.com> | 2017-03-22 00:03:30 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-03-22 00:03:30 -0400 |
| commit | 9e0ca927f950d1d396e3f45f02e0a3e7dd5b0fff (patch) | |
| tree | 78883bca7dd8fdae1621115f47b018e92ccb2c89 /keyboards/jd45 | |
| parent | c36a4496eb190c72c492000f38ab4e98a3681fe4 (diff) | |
| download | qmk_firmware-9e0ca927f950d1d396e3f45f02e0a3e7dd5b0fff.tar.gz qmk_firmware-9e0ca927f950d1d396e3f45f02e0a3e7dd5b0fff.zip | |
fixed a bug related to mod + Grave with combined ESC/Grave key
This only applies to keymaps that has combined esc/grave. Here we call it theKEY.
Think about the motion when we do shift + theKEY (typing ~), or CMD + theKEY (switching window on MAC). Based on the original code, we must do following sequence: press shift -> press theKEY -> release theKEY -> release shift. However, it is very possible and natural that we do this stroke sequence instead: press shift -> press theKEY -> release shift -> release theKEY.
If we do the 2nd stroke sequence, the code will del_key(ESC) instead of (GRV) when we release theKEY. This caused some inconvenient issues and ghost typing.
By adding a flag, this issue is eliminated and will not affect any other functions.
Diffstat (limited to 'keyboards/jd45')
0 files changed, 0 insertions, 0 deletions