summaryrefslogtreecommitdiff
path: root/keyboards/keyboardio
diff options
context:
space:
mode:
authorAntoine R. Dumont <ardumont@users.noreply.github.com>2021-06-24 04:24:31 +0200
committerGitHub <noreply@github.com>2021-06-24 12:24:31 +1000
commitf5cecffab2a32db5db9177aab79226a00013db81 (patch)
treebfd56b4309d9b9c5e2b910dbb986a5e62758fb3f /keyboards/keyboardio
parent5e86a11a8d49928f06609e9ee1b9ef86c45f3f2e (diff)
downloadqmk_firmware-f5cecffab2a32db5db9177aab79226a00013db81.tar.gz
qmk_firmware-f5cecffab2a32db5db9177aab79226a00013db81.zip
keymap/ardumont: Fix substitute keycode reset step (#12675)
It so happens that when releasing the control key prior to the main key (C-h, C-i, C-n, ...), the substituted keycode was continuously sent in a loop after that (even when releasing said key). The workaround so far was to type any other key to stop the loop. This commit fixes such behavior by resetting the substitution keycode sent when the ctrl released situation conditional is detected (and that the substitution keycode was on).
Diffstat (limited to 'keyboards/keyboardio')
-rw-r--r--keyboards/keyboardio/atreus/keymaps/ardumont/keymap.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/keyboards/keyboardio/atreus/keymaps/ardumont/keymap.c b/keyboards/keyboardio/atreus/keymaps/ardumont/keymap.c
index 3bde667ee9..6faabbc3ed 100644
--- a/keyboards/keyboardio/atreus/keymaps/ardumont/keymap.c
+++ b/keyboards/keyboardio/atreus/keymaps/ardumont/keymap.c
@@ -97,8 +97,7 @@ bool substitute_keycode(uint16_t keycode, keyrecord_t *record, uint8_t mod_state
// Do not let QMK process the keycode further
return false;
} else {
- // In case substitude_keycode is still being sent even after the release of
- // the key
+ // In case substitude_keycode is still even after release of the key
if (key_registered) {
unregister_code(substitute_keycode);
key_registered = false;
@@ -106,6 +105,12 @@ bool substitute_keycode(uint16_t keycode, keyrecord_t *record, uint8_t mod_state
return false;
}
}
+ } else { // ctrl got released
+ // In case substitude_keycode is still sent after release of the ctrl key
+ if (key_registered) {
+ unregister_code(substitute_keycode);
+ key_registered = false;
+ }
}
// Else, let QMK process the keycode as usual
return true;