diff options
author | Jay Greco <jayv.greco@gmail.com> | 2021-02-09 06:50:16 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-02-09 14:50:16 +0000 |
commit | 4107856b70eb686d2e151254ca73adf522312c49 (patch) | |
tree | 81b52ea7b24328f7d7c7baaa328be126d06bef64 /keyboards/nullbitsco/nibble/keymaps/iso/keymap.c | |
parent | 627ceebef3ed19eceba3642a830ffbf44f4a9e04 (diff) | |
download | qmk_firmware-4107856b70eb686d2e151254ca73adf522312c49.tar.gz qmk_firmware-4107856b70eb686d2e151254ca73adf522312c49.zip |
Simplify NIBBLE encoder code and clean up keymaps (#11808)
* Simplify encoder code and clean up keymaps.
-Removed overly complex VIA encoder code. It wasn't adding any value and was confusing users who were trying to customize encoder functionality on VIA keymaps.
-Replaced KC_TILDE with KC_HOME in all keymaps, as KC_TILDE sends a left shift, which was confusing some folks as they tested their build.
-Move layer names to enum
* Change encoder_update_kb to encoder_update_user per PR feedback
Diffstat (limited to 'keyboards/nullbitsco/nibble/keymaps/iso/keymap.c')
-rw-r--r-- | keyboards/nullbitsco/nibble/keymaps/iso/keymap.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/keyboards/nullbitsco/nibble/keymaps/iso/keymap.c b/keyboards/nullbitsco/nibble/keymaps/iso/keymap.c index 7e78b1f638..214034ef8e 100644 --- a/keyboards/nullbitsco/nibble/keymaps/iso/keymap.c +++ b/keyboards/nullbitsco/nibble/keymaps/iso/keymap.c @@ -15,8 +15,10 @@ */ #include QMK_KEYBOARD_H -#define _MA 0 -#define _FN 1 +enum layer_names { + _MA, + _FN +}; enum custom_keycodes { KC_CUST = SAFE_RANGE, @@ -103,7 +105,7 @@ void change_RGB(bool clockwise) { } } -void encoder_update_kb(uint8_t index, bool clockwise) { +void encoder_update_user(uint8_t index, bool clockwise) { if (layer_state_is(1)) { //change RGB settings change_RGB(clockwise); |