summaryrefslogtreecommitdiff
path: root/lib/python/qmk/cli/doctor/main.py
diff options
context:
space:
mode:
authorZach White <skullydazed@gmail.com>2021-09-27 10:02:54 -0700
committerGitHub <noreply@github.com>2021-09-27 10:02:54 -0700
commitfce9cb933845bf0b74d322eba02de3b76daaeb84 (patch)
treea28ffc6f3c53a4ddf1004f1a99938e2e5a42e6c3 /lib/python/qmk/cli/doctor/main.py
parent5f38a98fa07677be960b71b8e3b0a1785effe0d8 (diff)
downloadqmk_firmware-fce9cb933845bf0b74d322eba02de3b76daaeb84.tar.gz
qmk_firmware-fce9cb933845bf0b74d322eba02de3b76daaeb84.zip
Cleanup issues identified by lgtm (#14459)
* cleanup issues identified by lgtm * fix the git_status check
Diffstat (limited to 'lib/python/qmk/cli/doctor/main.py')
-rwxr-xr-xlib/python/qmk/cli/doctor/main.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/lib/python/qmk/cli/doctor/main.py b/lib/python/qmk/cli/doctor/main.py
index 6a31ccdfdd..ed20f46d3f 100755
--- a/lib/python/qmk/cli/doctor/main.py
+++ b/lib/python/qmk/cli/doctor/main.py
@@ -79,12 +79,13 @@ def doctor(cli):
cli.log.info('CLI version: %s', cli.version)
cli.log.info('QMK home: {fg_cyan}%s', QMK_FIRMWARE)
- status = os_tests()
+ status = os_status = os_tests()
+ git_status = git_tests()
- status = git_tests()
+ if git_status == CheckStatus.ERROR or (os_status == CheckStatus.OK and git_status == CheckStatus.WARNING):
+ status = git_status
- venv = in_virtualenv()
- if venv:
+ if in_virtualenv():
cli.log.info('CLI installed in virtualenv.')
# Make sure the basic CLI tools we need are available and can be executed.