From c6224236682c2ac40ccfe752c57fd3ec4905757f Mon Sep 17 00:00:00 2001 From: Martin Sandiford Date: Tue, 15 Aug 2017 10:38:29 +0930 Subject: Remove floating point calculation in mouse move. Saves approx 650 bytes if no other floating point used. --- tmk_core/common/mousekey.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) (limited to 'tmk_core/common') diff --git a/tmk_core/common/mousekey.c b/tmk_core/common/mousekey.c index 23469476e2..aa128f0e87 100644 --- a/tmk_core/common/mousekey.c +++ b/tmk_core/common/mousekey.c @@ -55,6 +55,14 @@ uint8_t mk_wheel_time_to_max = MOUSEKEY_WHEEL_TIME_TO_MAX; static uint16_t last_timer = 0; +inline int8_t times_inv_sqrt2(int8_t x) +{ + // 181/256 is pretty close to 1/sqrt(2) + // 0.70703125 0.707106781 + // 1 too small for x=99 and x=198 + // This ends up being a mult and discard lower 8 bits + return (x * 181) >> 8; +} static uint8_t move_unit(void) { @@ -111,10 +119,10 @@ void mousekey_task(void) if (mouse_report.y > 0) mouse_report.y = move_unit(); if (mouse_report.y < 0) mouse_report.y = move_unit() * -1; - /* diagonal move [1/sqrt(2) = 0.7] */ + /* diagonal move [1/sqrt(2)] */ if (mouse_report.x && mouse_report.y) { - mouse_report.x *= 0.7; - mouse_report.y *= 0.7; + mouse_report.x = times_inv_sqrt2(mouse_report.x); + mouse_report.y = times_inv_sqrt2(mouse_report.y); } if (mouse_report.v > 0) mouse_report.v = wheel_unit(); -- cgit v1.2.1